Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): implement single version policy generator #26437

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jan 20, 2023

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@Hotell Hotell changed the title Hotell/build/svp/repo feat(tools): implement single version policy generator Jan 20, 2023
@size-auditor
Copy link

size-auditor bot commented Jan 20, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 06505b5c50c6deedcb36b29417cf35b77da85cfc (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1279 1309 5000
Button mount 942 916 5000
FluentProvider mount 1516 1489 5000
FluentProviderWithTheme mount 581 587 10
FluentProviderWithTheme virtual-rerender 542 549 10
FluentProviderWithTheme virtual-rerender-with-unmount 583 568 10
InfoButton mount 526 517 5000
MakeStyles mount 1968 1941 50000
Persona mount 2801 2793 5000
SpinButton mount 2388 2315 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c712f5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.182 kB
1.308 kB
react-accordion
Accordion (including children components)
80.097 kB
24.712 kB
react-alert
Alert
85.912 kB
21.686 kB
react-avatar
Avatar
52.812 kB
14.689 kB
react-avatar
AvatarGroup
15.42 kB
6.167 kB
react-avatar
AvatarGroupItem
69.03 kB
18.984 kB
react-badge
Badge
23.78 kB
7.542 kB
react-badge
CounterBadge
24.67 kB
7.825 kB
react-badge
PresenceBadge
25.728 kB
7.439 kB
react-button
Button
33.354 kB
8.779 kB
react-button
CompoundButton
40.384 kB
10.127 kB
react-button
MenuButton
38.043 kB
10.096 kB
react-button
SplitButton
45.488 kB
11.501 kB
react-button
ToggleButton
49.184 kB
10.875 kB
react-card
Card - All
77.975 kB
22.496 kB
react-card
Card
72.92 kB
21.108 kB
react-card
CardFooter
9.04 kB
3.807 kB
react-card
CardHeader
10.805 kB
4.443 kB
react-card
CardPreview
9.847 kB
4.159 kB
react-checkbox
Checkbox
32.658 kB
10.169 kB
react-checkbox
CheckboxField
39.424 kB
11.981 kB
react-combobox
Combobox (including child components)
80.888 kB
25.842 kB
react-combobox
ComboboxField
78.742 kB
25.974 kB
react-combobox
Dropdown (including child components)
79.674 kB
25.637 kB
react-components
react-components: Button, FluentProvider & webLightTheme
59.888 kB
16.652 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.539 kB
52.638 kB
react-components
react-components: FluentProvider & webLightTheme
34.379 kB
11.322 kB
react-dialog
Dialog (including children components)
83.464 kB
24.916 kB
react-divider
Divider
16.938 kB
6.103 kB
react-image
Image
11.259 kB
4.473 kB
react-infobutton
InfoButton
118.422 kB
35.99 kB
react-input
Input
24.673 kB
8.065 kB
react-input
InputField
34.574 kB
10.897 kB
react-label
Label
9.817 kB
4.067 kB
react-link
Link
12.285 kB
5.063 kB
react-menu
Menu (including children components)
117.988 kB
36.475 kB
react-menu
Menu (including selectable components)
121.057 kB
36.981 kB
react-overflow
hooks only
11.033 kB
4.198 kB
react-persona
Persona
58.849 kB
16.348 kB
react-popover
Popover
105.54 kB
32.507 kB
react-portal
Portal
11.086 kB
4.093 kB
react-portal-compat
PortalCompatProvider
6.069 kB
2.053 kB
react-positioning
usePositioning
20.856 kB
7.766 kB
react-progress
ProgressBar
13.573 kB
5.232 kB
react-progress
ProgressField
23.563 kB
8.229 kB
react-provider
FluentProvider
16.446 kB
6.127 kB
react-radio
Radio
32.247 kB
10.468 kB
react-radio
RadioGroup
14.718 kB
5.886 kB
react-radio
RadioGroupField
24.699 kB
8.936 kB
react-select
Select
23.963 kB
8.206 kB
react-select
SelectField
32.901 kB
10.588 kB
react-slider
Slider
32.663 kB
10.403 kB
react-slider
SliderField
42.366 kB
13.247 kB
react-spinbutton
SpinButton
44.989 kB
12.975 kB
react-spinbutton
SpinButtonField
53.95 kB
15.403 kB
react-spinner
Spinner
20.445 kB
6.621 kB
react-switch
Switch
27.791 kB
8.605 kB
react-switch
SwitchField
34.45 kB
10.413 kB
react-table
DataGrid
129.317 kB
35.207 kB
react-table
Table (Primitives only)
42.971 kB
11.781 kB
react-table
Table as DataGrid
127.563 kB
32.864 kB
react-table
Table (Selection only)
81 kB
20.124 kB
react-table
Table (Sort only)
80.429 kB
19.97 kB
react-text
Text - Default
12.261 kB
4.819 kB
react-text
Text - Wrappers
15.571 kB
5.23 kB
react-textarea
Textarea
26.156 kB
8.508 kB
react-textarea
TextareaField
36.057 kB
11.3 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
30.908 kB
6.714 kB
react-theme
Teams: Light theme
17.776 kB
5.141 kB
react-tooltip
Tooltip
43.49 kB
15.213 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 06505b5c50c6deedcb36b29417cf35b77da85cfc

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1197 1201 5000
Breadcrumb mount 2789 2802 1000
Checkbox mount 2653 2647 5000
CheckboxBase mount 2351 2370 5000
ChoiceGroup mount 4285 4262 5000
ComboBox mount 1169 1170 1000
CommandBar mount 9311 9230 1000
ContextualMenu mount 10114 10149 1000
DefaultButton mount 1377 1368 5000
DetailsRow mount 3367 3352 5000
DetailsRowFast mount 3367 3353 5000
DetailsRowNoStyles mount 3223 3240 5000
Dialog mount 2964 2979 1000
DocumentCardTitle mount 580 574 1000
Dropdown mount 3132 3175 5000
FocusTrapZone mount 1956 1997 5000
FocusZone mount 2005 1959 5000
GroupedList mount 1855 2036 2
GroupedList virtual-rerender 1088 1088 2
GroupedList virtual-rerender-with-unmount 1593 1596 2
GroupedListV2 mount 561 564 2
GroupedListV2 virtual-rerender 553 549 2
GroupedListV2 virtual-rerender-with-unmount 567 565 2
IconButton mount 1802 1807 5000
Label mount 737 744 5000
Layer mount 4174 4209 5000
Link mount 853 839 5000
MenuButton mount 1626 1605 5000
MessageBar mount 2322 2327 5000
Nav mount 3047 3072 1000
OverflowSet mount 1410 1431 5000
Panel mount 2487 2496 1000
Persona mount 1312 1275 1000
Pivot mount 1489 1508 1000
PrimaryButton mount 1501 1490 5000
Rating mount 6927 6967 5000
SearchBox mount 1519 1500 5000
Shimmer mount 2940 2925 5000
Slider mount 2138 2119 5000
SpinButton mount 4261 4314 5000
Spinner mount 839 832 5000
SplitButton mount 2862 2862 5000
Stack mount 872 867 5000
StackWithIntrinsicChildren mount 2255 2247 5000
StackWithTextChildren mount 4942 4922 5000
SwatchColorPicker mount 9388 9424 5000
TagPicker mount 2326 2329 5000
TeachingBubble mount 76075 76156 5000
Text mount 814 808 5000
TextField mount 1546 1550 5000
ThemeProvider mount 1444 1444 5000
ThemeProvider virtual-rerender 1141 1148 5000
ThemeProvider virtual-rerender-with-unmount 2006 2011 5000
Toggle mount 1138 1134 5000
buttonNative mount 537 537 5000

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v0 No visual regressions between this PR and main

@msft-fluent-ui-bot
Copy link
Collaborator

Because this pull request has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

The pull request will still be available for reference. If it's still relevant to merge at some point, you can reopen or make a new version based on the latest code.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Jun 19, 2023
@Hotell Hotell reopened this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Soft Close Soft closing inactive issues over a certain period Status: Do Not Merge 🚫
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants